Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update currency symbol for MKD #891

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Update currency symbol for MKD #891

merged 2 commits into from
Sep 13, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Sep 10, 2024

Fixes #890


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Sep 10, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl None 0.20.0-wip 0.20.0-wip 0.20.0-wip ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage
pkgs/intl/lib/src/intl/constants.dart 💚 100 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
intl _DateFormatField
StringStack
DateBuilder

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️
Package Version Status
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl4x 0.10.1 already published at pub.dev
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem marked this pull request as ready for review September 13, 2024 09:06
@mosuem mosuem enabled auto-merge (squash) September 13, 2024 09:06
@mosuem mosuem merged commit 8ec20fc into main Sep 13, 2024
14 checks passed
@mosuem mosuem deleted the mosuem-patch-1 branch September 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currency symbol for MKD is den but here it's din
2 participants