Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include _onNativeJit in broadNative? #1028

Open
jonasfj opened this issue Mar 7, 2022 · 4 comments
Open

Include _onNativeJit in broadNative? #1028

jonasfj opened this issue Mar 7, 2022 · 4 comments
Assignees
@sigurdm
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jonasfj
Copy link
Member

jonasfj commented Mar 7, 2022

Include _onNativeJit in broadNative?
https://github.com/dart-lang/pana/blob/master/lib/src/tag/_specs.dart#L103-L108

Otherwise, we won't detect platforms tags for anything importing things like dart:cli, see:
https://pub.dev/packages/winmd/score

I think _onNativeJit shouldn't be part of broadFlutter, so we won't detect sdk:flutter when dart:mirrors is used.
@jonasfj jonasfj added Area: pana-related type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Area: pana-related labels Mar 7, 2022
@jonasfj
Copy link
Member Author

jonasfj commented Mar 7, 2022

@sigurdm, agree?

@sigurdm
Copy link
Contributor

sigurdm commented Mar 8, 2022

Yes, I think that makes good sense!

@sigurdm sigurdm self-assigned this Mar 24, 2022
@isoos isoos mentioned this issue Aug 5, 2022
Closed
@isoos
Copy link
Collaborator

isoos commented Oct 17, 2022 •
edited
Loading

The current analysis of webmd is much more strange than before:
Edit: my bad, nothing wrong with this screenshot, deleting.

@sigurdm
Copy link
Contributor

sigurdm commented Nov 23, 2023

We should investigate this again. Seems it is not trivial to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigurdm sigurdm

Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand broadNative runtime with nativeJit. isoos/pana
3 participants
@jonasfj @isoos @sigurdm