Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make "dart format" check non-scoring check #1399

Open
jonasfj opened this issue Sep 27, 2024 · 1 comment
Open

make "dart format" check non-scoring check #1399

jonasfj opened this issue Sep 27, 2024 · 1 comment
Labels
type-enhancement A request for a change that isn't a bug

Comments

@jonasfj
Copy link
Member

jonasfj commented Sep 27, 2024

When/if the default line width for dart format becomes configurable, as being discussed in dart-lang/dart_style#833, we should do the following:

  • Stop granting point for code being formatted with "dart format".
  • Make a suggestion when code is not formatted with "dart format" (but not points deducted).
  • Increase point for up-to-date dependencies from 10 to 20 points.
    (Ensuring overall points remain the same).

Reasoning: Code formatting does not imply quality. But we do want to make people aware that formatting is a thing, if they haven't otherwise discovered it.

@jonasfj jonasfj added the type-enhancement A request for a change that isn't a bug label Sep 27, 2024
@Levi-Lesches
Copy link

I don't know if the feature is widely available yet, but that issue has been closed ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants