Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper pub points not given #7129

Open
quetool opened this issue Oct 18, 2023 · 5 comments
Open

Proper pub points not given #7129

quetool opened this issue Oct 18, 2023 · 5 comments

Comments

@quetool
Copy link

quetool commented Oct 18, 2023

URL: https://pub.dev/packages/web3modal_flutter/versions/3.0.0-beta04

Hello, on the package linked above☝️ there is a proper LICENSE file filled with an OSI-approved License however it's not being recognized as such.

@quetool
Copy link
Author

quetool commented Oct 18, 2023

We can see how dio_cache_interceptor package is using the very same LICENSE as we do but it's being recognized properly for them but not for our package https://pub.dev/packages/dio_cache_interceptor/license

@quetool
Copy link
Author

quetool commented Oct 18, 2023

Only after hitting documentation points on latest version the license was recognized. Not sure if it's a bug or not but IMHO license recognition should be independent from documentation analysis.

https://pub.dev/packages/web3modal_flutter/versions/3.0.0-beta04/score

Vs

https://pub.dev/packages/web3modal_flutter/versions/3.0.0-beta06/score

@isoos
Copy link
Collaborator

isoos commented Oct 18, 2023

@quetool: thanks for reporting! A few notes:

@quetool
Copy link
Author

quetool commented Oct 19, 2023

Thanks for answering @isoos !
Indeed I figured "hey, maybe the appendix is important for the recognition tool" and I added it, although I would have never said it :)
Didn't know it was that important

@isoos
Copy link
Collaborator

isoos commented Oct 19, 2023

It is not the appendix that is important, rather, overall, the difference from the "canonical" (or one of the many canonical) text content. Putting the appendix back moved the license over the (otherwise strict) detection threshold. It is important to report these issues, otherwise fixing these won't get a high priority in the near future...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants