Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more total values into heap snapshot. #53135

Open
polina-c opened this issue Aug 7, 2023 · 3 comments
Open

Include more total values into heap snapshot. #53135

polina-c opened this issue Aug 7, 2023 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug

Comments

@polina-c
Copy link
Contributor

polina-c commented Aug 7, 2023

At the moment heap snapshot contains heap size, but does not contain rss. So, it is hard to connect numbers exposed to the process with ProcessInfo.currentRss, numbers in memory monitor, and numbers in heap snapshot.

Also, now when external size of objects is not accurate, totals are more needed to get some visibility on external size allocations.

Now devtools heap snapshot shows just two numbers: heap and reachanble.
It would be great to show also rss and external, to be able to compare them between snapshots.

@polina-c
Copy link
Contributor Author

polina-c commented Aug 7, 2023

@bkonyi

@lrhn lrhn added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Aug 7, 2023
@a-siva a-siva added the type-enhancement A request for a change that isn't a bug label Nov 16, 2023
@a-siva
Copy link
Contributor

a-siva commented Nov 16, 2023

@polina-c it should be possible for you to get that information using vm service while grabbing the heap snapshot and write it into a side file which can be used along with the heap snapshot.
One concern with adding this info into the current heap snapshot is that it would be a breaking change.

@a-siva a-siva added the triaged Issue has been triaged by sub team label Nov 16, 2023
@polina-c
Copy link
Contributor Author

Heap snapshot is an async operation.
If i get total values separately, it may not correspond to the snapshotted state of application. And, actually, may diff significantly.

Why it is breaking change?
Because os serialization?
These values may be nullable and ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants