Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Pub: Properly handle case where the client is unable to fetch advisories #55981

Closed
sigurdm opened this issue Jun 11, 2024 · 4 comments
Closed

[CP] Pub: Properly handle case where the client is unable to fetch advisories #55981

sigurdm opened this issue Jun 11, 2024 · 4 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@sigurdm
Copy link
Contributor

sigurdm commented Jun 11, 2024

Commit(s) to merge

Landed in pub as dart-lang/pub@e05f76b
Rolled to sdk in https://dart-review.googlesource.com/c/sdk/+/370882

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/370885

Issue Description

When attempting to fetch advisories from a pub server, the client would crash if they were not available.

This breaks pub for mirrors of pub.dev that fail to proxy advisories.

What is the fix

Print a warning instead of crashing

Why cherry-pick

This impacts users of mirrors that have not been updated to mirror advisories - they are not able to get a resolution with pub.

Risk

Medium-low

Issue link(s)

dart-lang/pub#4269

Extra Info

No response
@sigurdm sigurdm added the cherry-pick-review Issue that need cherry pick triage to approve label Jun 11, 2024
@mit-mit
Copy link
Member

mit-mit commented Jun 11, 2024

sgtm

@sigurdm
Copy link
Contributor Author

sigurdm commented Jun 11, 2024

cc @szakarias

@athomas
Copy link
Member

athomas commented Jun 11, 2024

Small change, good coverage, LGTM

@athomas athomas added the cherry-pick-approved Label for approved cherrypick request label Jun 11, 2024
@devoncarew devoncarew added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Jun 12, 2024
@athomas
Copy link
Member

athomas commented Jun 13, 2024

Released in 3.4.4.

@athomas athomas closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@devoncarew @vsmenon @sigurdm @itsjustkevin @mit-mit @athomas