Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve interface of DartToolingDaemon.call() #55999

Closed
CoderDake opened this issue Jun 13, 2024 · 2 comments
Closed

Improve interface of DartToolingDaemon.call() #55999

CoderDake opened this issue Jun 13, 2024 · 2 comments
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool P2 A bug or feature request we're likely to work on pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK) triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug

Comments

@CoderDake
Copy link

DartToolingDaemon.call() takes Map<String, Object>? and not Map<String, Object?>? which makes it a little more difficult to use with potentially nullable values.
@CoderDake CoderDake added P2 A bug or feature request we're likely to work on dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool labels Jun 13, 2024
@dart-github-bot
Copy link
Collaborator

area-dart-cli, type-enhancement

The DartToolingDaemon.call() method currently accepts a non-nullable Map<String, Object> argument, making it inconvenient to pass potentially nullable values. The issue suggests changing the argument type to Map<String, Object?>? for improved flexibility.

@dart-github-bot dart-github-bot added area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Jun 13, 2024
@kenzieschmoll kenzieschmoll added the pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK) label Jul 8, 2024
@kenzieschmoll
Copy link
Contributor

Fixed by a98c019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool P2 A bug or feature request we're likely to work on pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK) triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CoderDake @kenzieschmoll @dart-github-bot