Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Top Level to File supporting part files #56885

Open
Tracked by #56203
FMorschel opened this issue Oct 11, 2024 · 1 comment
Open
Tracked by #56203

Move Top Level to File supporting part files #56885

FMorschel opened this issue Oct 11, 2024 · 1 comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-enhanced-parts Regarding the 'enhanced-parts' feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@FMorschel
Copy link
Contributor

FMorschel commented Oct 11, 2024

Today if you try to call "Move Top Level to File" on files with parts or part files there is no prompt. I suspect that it has some limitations to the implementation, but I'd like to ask for this to be done after the new enhanced parts release.

I'd also like to point out that similar to this request about asking if the new file should be exported on the original file (so imports don't move) we could have a similar thing (once we can figure out a way of prompting this) about adding new import lines on the part file (if we make one) or keep using the source file imports.

@dart-github-bot
Copy link
Collaborator

Summary: The "Move Top Level to File" refactoring currently doesn't handle files with parts or part files. The user requests this functionality to be implemented after the release of enhanced parts, suggesting a similar prompt to the one in issue #56692 for handling imports.

@dart-github-bot dart-github-bot added area-intellij Tracking issues for the Dart IntelliJ plugin. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Oct 11, 2024
@lrhn lrhn added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. and removed area-intellij Tracking issues for the Dart IntelliJ plugin. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. labels Oct 13, 2024
@pq pq added the feature-enhanced-parts Regarding the 'enhanced-parts' feature label Oct 15, 2024
@pq pq added the P2 A bug or feature request we're likely to work on label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-enhanced-parts Regarding the 'enhanced-parts' feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
Development

No branches or pull requests

4 participants