Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart fix --dry-run should support returning non-zero code on changes for CI uses #56904

Open
artoale opened this issue Oct 16, 2024 · 1 comment
Open

dart fix --dry-run should support returning non-zero code on changes for CI uses #56904

artoale opened this issue Oct 16, 2024 · 1 comment
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. type-enhancement A request for a change that isn't a bug

Comments

@artoale
Copy link

artoale commented Oct 16, 2024

This is equivalent to #44023 , but for dart fix
We just assumed it would return non zero when there are fixes to apply in our CI, and later realised it does not :)

  • Dart 3.5.1 (stable) (Tue Aug 13 21:02:17 2024 +0000) on "macos_arm64"
  • on macos / Version 14.6.1 (Build 23G93)
  • locale is en-IT
@dart-github-bot
Copy link
Collaborator

Summary: The dart fix --dry-run command currently does not return a non-zero exit code when fixes are available, making it difficult to use in CI environments. This issue proposes adding this functionality for consistency with similar tools.

@dart-github-bot dart-github-bot added area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Oct 16, 2024
@lrhn lrhn removed the triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@artoale @lrhn @dart-github-bot