Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name from ModuleMetadata #59618

Open
srujzs opened this issue Nov 26, 2024 · 0 comments
Open

Remove name from ModuleMetadata #59618

srujzs opened this issue Nov 26, 2024 · 0 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler

Comments

@srujzs
Copy link
Contributor

srujzs commented Nov 26, 2024

Today, DDC emits metadata about the modules it emits, including the name, URI, library metadata, source mappings, and more.

With the new library bundle module format (which will become the only format), library bundles do not have a name associated with them. Today, we emit unused for the name:

. This will be a breaking change and downstream uses need to be refactored once we move off of all the other module formats (note that this can't happen sooner since require.js needs module names). There is support for versioning today, so we should leverage that:
class ModuleMetadataVersion {
.

@srujzs srujzs added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler
Projects
None yet
Development

No branches or pull requests

1 participant