Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to allow for an unnamed library #1141

Closed
devoncarew opened this issue Nov 28, 2023 · 3 comments
Closed

update to allow for an unnamed library #1141

devoncarew opened this issue Nov 28, 2023 · 3 comments
Labels
package:code_builder type-enhancement A request for a change that isn't a bug

Comments

@devoncarew
Copy link
Member

When trying to add an annotation to a library w/o a name, I get:

Bad state: a library name is required for annotations

However, as of a recent (3.0?) version of Dart, we no longer require library names for library directives.
@devoncarew devoncarew added the type-enhancement A request for a change that isn't a bug label Nov 28, 2023
@srawlins
Copy link
Member

I'm happy to make this fix

@devoncarew
Copy link
Member Author

That would be great! I ran into this while working on package:web (generated code from the Web IDLs) and had to work around the issue.

@devoncarew
Copy link
Member Author

fixed by dart-archive/code_builder#440

@mosuem mosuem transferred this issue from dart-archive/code_builder Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:code_builder type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srawlins @devoncarew @mosuem