Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement Request] expose the trading constants so we can create/modify orders symbolically #72

Open
metaperl opened this issue Apr 2, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@metaperl
Copy link

metaperl commented Apr 2, 2020

the sample code in the README shows how to create a default order but not how to modify such an order. Without enumerated types for the various order properties, we cannot write easy to read code to modify the order.

The constants are even in the code as comments:

         // OP_BUY = 0
         // OP_SELL = 1
         // OP_BUYLIMIT = 2
         // OP_SELLLIMIT = 3
         // OP_BUYSTOP = 4
         // OP_SELLSTOP = 5

but they should be in the code as actual values so someone importing the module can use them.

@integracore2 integracore2 self-assigned this Apr 16, 2020
@integracore2 integracore2 added the enhancement New feature or request label Apr 16, 2020
@integracore2
Copy link
Collaborator

Thank you for raising this @metaperl 🙂

You make a good point indeed. We'll escalate this and commit a patch to the code as soon as we can.

Many thanks for your valuable inputs - much appreciated!

@integracore2 integracore2 changed the title expose the trading constants so we can create/modify orders symbolically [Enhancement Request] expose the trading constants so we can create/modify orders symbolically Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants