From 71b62a0feae7daf683b5d89fa55dca4b86dd289c Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Mon, 12 Aug 2024 14:23:26 +0200 Subject: [PATCH 1/4] Support PHP 8.4 foo(string $bar = null) is deprecated, use foo(?string $bar = null) instead. --- src/Exceptions/NestingException.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Exceptions/NestingException.php b/src/Exceptions/NestingException.php index 474b987..7acc842 100644 --- a/src/Exceptions/NestingException.php +++ b/src/Exceptions/NestingException.php @@ -18,7 +18,7 @@ class NestingException extends \Exception * @param Exception|null $previous * @param \DOMElement|null $element */ - public function __construct($message = "", $code = 0, Exception $previous = null, \DOMElement $element = null) + public function __construct($message = "", $code = 0, ?Exception $previous = null, ?\DOMElement $element = null) { $this->element = $element; parent::__construct($message, $code, $previous); From c0b26c3541f7153d438ebdf4494ee2bd98a654ae Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Mon, 12 Aug 2024 14:25:53 +0200 Subject: [PATCH 2/4] Add PHP 8.4 to test matrix --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 33cbefd..a881b21 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: - php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3'] + php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4'] fail-fast: false steps: From fd26ab8996126501b2cfd6eef6d6b8e416e2845d Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Mon, 12 Aug 2024 14:27:45 +0200 Subject: [PATCH 3/4] Require PHP ^7.1 PHP 5.6 and 7.0 are so old that the don't support the '?' nullable parameter. Do support PH> 8.4, these versions have to be dropped now. --- .github/workflows/tests.yml | 2 +- composer.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a881b21..dbda22d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: - php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4'] + php: ['7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4'] fail-fast: false steps: diff --git a/composer.json b/composer.json index cb413dc..81c67d3 100644 --- a/composer.json +++ b/composer.json @@ -25,9 +25,9 @@ "require": { "ext-dom": "*", "ext-libxml": "*", - "php": "^5.6 || ^7.0 || ^8.0" + "php": "^7.1 || ^8.0" }, "require-dev": { - "phpunit/phpunit": "^5.7 || ^6.5 || ^8.5" + "phpunit/phpunit": "^6.5 || ^8.5" } } From 7dd11e47abe71e8aaeb089d453e3b5a99923e38c Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Mon, 12 Aug 2024 14:30:40 +0200 Subject: [PATCH 4/4] Use actions/checkout@v4, v3 is deprecated --- .github/workflows/codeclimate.yml | 2 +- .github/workflows/tests.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/codeclimate.yml b/.github/workflows/codeclimate.yml index b137659..a82ff93 100644 --- a/.github/workflows/codeclimate.yml +++ b/.github/workflows/codeclimate.yml @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup PHP uses: shivammathur/setup-php@v2 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index dbda22d..f271c62 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,7 +12,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup PHP uses: shivammathur/setup-php@v2