Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ambiguity of SemanticOps.xtagDataSet when T->(X,Y,Z) #63

Open
jbfaden opened this issue Jul 9, 2023 · 1 comment
Open

ambiguity of SemanticOps.xtagDataSet when T->(X,Y,Z) #63

jbfaden opened this issue Jul 9, 2023 · 1 comment

Comments

@jbfaden
Copy link
Member

jbfaden commented Jul 9, 2023

I made what I thought was a trivial change to bundle which shows an ambiguity with SemanticOps.xtagDataSet when a bundle of X,Y,Z is the argument, when X itself has timetags with DEPEND_0. The bundle command was made to preserve the timetags, so that the bundle itself would have the timetags of the bundled datasets. The problem is xtagDataSet was expected to return "X" of the bundle, but since there is a DEPEND_0, T was returned instead.

Some thought and thorough testing is needed for this change. For example, if (T->X,T->Y)->Z, should X simply be returned? X is an independent variable, so it seems appropriate. Often a bundle is just X,Y,Z, so how does one know that X is an independent variable?

@jbfaden
Copy link
Member Author

jbfaden commented Jul 9, 2023

There's a comment in BundleDataSet.java, "This can't be done carelessly, because test037_breakCounter_2 shows a problem." I'm sure this is the same bug.

jbfaden added a commit that referenced this issue Jul 9, 2023
jbfaden added a commit that referenced this issue Jul 9, 2023
recent change which shows the issue.
jbfaden added a commit that referenced this issue Jul 10, 2023
recent change which shows the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant