Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codacy coverage information not enabled #1024

Open
benjamingeer opened this issue Oct 31, 2018 · 19 comments
Open

Codacy coverage information not enabled #1024

benjamingeer opened this issue Oct 31, 2018 · 19 comments
Assignees
Labels
bug something isn't working

Comments

@benjamingeer
Copy link

It looks like #1021 didn't work:

screen shot 2018-10-31 at 19 40 48

@benjamingeer benjamingeer added the bug something isn't working label Oct 31, 2018
@benjamingeer
Copy link
Author

Also there doesn't seem to be any coverage information for this PR:

#1011

@subotic
Copy link
Collaborator

subotic commented Oct 31, 2018

It is, but it is here: https://app.codacy.com/project/dhlab-basel/Knora/dashboard

I don't know, why this PR points to your dashboard. Maybe you could try to remove the Knora project from your personal dashboard?

@benjamingeer
Copy link
Author

It is, but it is here: https://app.codacy.com/project/dhlab-basel/Knora/dashboard

Is there something there about coverage for particular PRs? I can't find it. And when I follow the Codacy/PR Quality Review links directly from our other PRs on GitHub, I also don't find any coverage information.

Maybe you could try to remove the Knora project from your personal dashboard?

I can't find any way to do that...

@subotic
Copy link
Collaborator

subotic commented Nov 1, 2018

@benjamingeer
Copy link
Author

The options described there are “remove your project from Codacy” or “transfer your project to another of your organizations”. I guess the first option isn’t what we want. With the second option, I tried to transfer the Knora project to the dhlab-basel organisation, but it says “You need to choose at least one team.”

@benjamingeer
Copy link
Author

15050e10-2cc9-4632-8574-cc1d085fba9e

@subotic
Copy link
Collaborator

subotic commented Nov 1, 2018

Yes, the first option would be the correct one.

@subotic
Copy link
Collaborator

subotic commented Nov 1, 2018

The project is already part of the dhlab-basel team dashboard. Codacy is a bit confusing. You can add the same project to different dashboards.

@subotic
Copy link
Collaborator

subotic commented Nov 1, 2018

or you can try to transfer it. lets see what happens ;-)

@benjamingeer
Copy link
Author

OK, I took the first option. Now I see the project under dhlab-basel, but it still doesn't have coverage information. It says "You need to request someone with write permissions to setup coverage".

screen shot 2018-11-02 at 12 27 06

@benjamingeer
Copy link
Author

Also, now I don't see a settings button anymore, so I can't change the code quality options, and Codacy is spamming my pull request with silly comments.

@subotic
Copy link
Collaborator

subotic commented Nov 2, 2018

and Codacy is spamming my pull request with silly comments

code review ;-)

I think I turned this on yesterday. I deactivated it now. Let's see if this will lower the verbosity of codacy.

As for the coverage, sometimes it shows and sometimes it doesn't. I'm not sure why.

@benjamingeer
Copy link
Author

benjamingeer commented Nov 2, 2018

Let's see if this will lower the verbosity of codacy.

OK, but I still want to be able to change Codacy's settings:

  • allow calling .head on a collection and .get on an Option, because this is something I do a lot in tests
  • allow a method longer than 50 lines
  • allow a method with more than 8 parameters

Before I "removed Knora from Codacy", I was able to change these settings. But now I don't even have a settings button to click anymore. Could this be because I don't have sufficient permissions in Codacy?

@subotic
Copy link
Collaborator

subotic commented Nov 2, 2018

I gave you admin permissions. Now you should be able to change any settings :-)

@benjamingeer
Copy link
Author

Great, now I can add a rule that all variable names must be exactly one character long. :)

@subotic
Copy link
Collaborator

subotic commented Nov 2, 2018

I see coverage now:

screenshot 2018-11-02 13 51 16

@subotic
Copy link
Collaborator

subotic commented Nov 2, 2018

:-)

@benjamingeer
Copy link
Author

I see the coverage for the project, but I don't see it for my pull request:

https://app.codacy.com/app/dhlab-basel/Knora/pullRequest?prid=2444057

Maybe Codacy only provides coverage information for develop, not for other branches or for PRs?

@subotic
Copy link
Collaborator

subotic commented Nov 2, 2018

Yay, we got an A from Codacy :-)

@subotic subotic added this to the Backlog milestone Feb 7, 2020
@irinaschubert irinaschubert removed this from the Backlog milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants