Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and fix 2 warnings #34

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

vanjacosic
Copy link

  • Updated dependencies and ran tests ✅

  • Fixed the following compile warning re. deprecation of push_redirect/2:

    ==> broadway_dashboard
    Compiling 7 files (.ex)
        warning: Phoenix.LiveView.push_redirect/2 is deprecated. Use push_navigate/2 instead
        │
     97 │             {:ok, push_redirect(socket, to: to)}
        │                   ~
        │
        └─ lib/broadway_dashboard.ex:97:19: BroadwayDashboard.mount/3
    
  • Fixed the following Dialyzer warning about an 'unknown type':

    lib/broadway_dashboard/pipeline_graph.ex:19:72:unknown_type
    Unknown type: BroadwayDashboard.LiveDashboard.LayeGraphComponent.layer/0.
    

    Seems to have been an old typo that was never caught.

I ran tests and mix dev multiple times and everything seems to work, but please double check 😅

@philss
Copy link
Member

philss commented Jul 3, 2024

@vanjacosic thanks for this! I think we need to bump the minimum Elixir version for this to work. Can you take a look?

@vanjacosic
Copy link
Author

@philss Done 😊

Macro.Env.lookup_import/2 was introduced in 1.13, so I tested with locally with Elixir 1.13.4 and Erlang 24.3.4.17 and that worked.
So I bumped the minimum to 1.13, which also brings this project in line with phoenix_live_view, floki and ex_doc.

elixir: 1.12.3
otp: 24.3.4
elixir: 1.13.4
otp: 24.3.4.17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanjacosic Can we support Elixir 1.17.x and Erlang OTP 27.x in the CI pipeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants