add bytes/2 combinator #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new combinator bytes/2. The combinator will pull the next n bytes from the input. It combiles to a byte-size pattern match on the input.
josevalim
reviewed
Dec 6, 2023
josevalim
reviewed
Dec 6, 2023
josevalim
reviewed
Dec 6, 2023
josevalim
reviewed
Dec 6, 2023
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
bytes/2combinator ( #131). This combinator allows a user to pull the nextnbytes from the input. It will compile to abinary-sizepattern match on the input string and will return a parsing error if there are insufficient bytes.@josevalim, I know that in #30, you proposed a
binary_sizecombinator which seems to take this idea further. From what I can tell, it would add similar compile time optimizations to other bounded combinators. However,byteswas also included as a secondary combinator in that proposal.