Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

dotenv variable names are inconsistent between Drive and DAPI #319

Open
cloudwheels opened this issue Mar 8, 2020 · 3 comments
Open

dotenv variable names are inconsistent between Drive and DAPI #319

cloudwheels opened this issue Mar 8, 2020 · 3 comments

Comments

@cloudwheels
Copy link

(Low Priority)
Common environment variables are used inconsistently between the Drive and Dapi libraries.
@cloudwheels cloudwheels changed the title dotenv variables name are inconsistent between Drive and DAPI dotenv variable names are inconsistent between Drive and DAPI Mar 8, 2020
@shumkov
Copy link
Member

shumkov commented Apr 19, 2020

Could you please specify which one?

@cloudwheels
Copy link
Author

Drive Dapi
CORE_JSON_RPC_HOST DASHCORE_RPC_HOST
CORE_JSON_RPC_PORT DASHCORE_RPC_PORT
CORE_JSON_RPC_USERNAME DASHCORE_RPC_USER
CORE_JSON_RPC_PASSWORD DASHCORE_RPC_PASS

@shumkov
Copy link
Member

shumkov commented May 23, 2020 •
edited
Loading

It seems in Drive are right once. We renamed dashcore to core at some point. Your PR is appritiated :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shumkov @cloudwheels