Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: API broken by Dashfetch - needs to lightly wrap each function #25

Closed
coolaj86 opened this issue Mar 24, 2023 · 1 comment
Closed

Comments

@coolaj86
Copy link
Member

coolaj86 commented Mar 24, 2023

This used to return something like:

{
  ok: true,
  statusCode: 200,
  status: "OK",
  body: textOrJson,
  headers: { "Key": "value" },
}

Now things that depended on it are broken and errors that may come from resp.json() or resp.text() will not be handled properly.

It needs to be changed back to keep API compat (and be more useful to the things that use it).

cc/ @jojobyte Changing this back will probably break some of your stuff too.

@coolaj86
Copy link
Member Author

coolaj86 commented Mar 26, 2023

Turns out the node code was completely broken.

Will be fixed by #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant