From 467fc0bb56b9b786b1f276dcf217869b5450b190 Mon Sep 17 00:00:00 2001 From: jojobyte <184880+jojobyte@users.noreply.github.com> Date: Wed, 7 Feb 2024 15:56:24 -0700 Subject: [PATCH 01/47] docs: :memo: Update TODO's --- TODO.md | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/TODO.md b/TODO.md index bc4c2e7..287c886 100644 --- a/TODO.md +++ b/TODO.md @@ -19,4 +19,29 @@ - [x] Enforce unique Aliases - [x] Should be able to add a contact by normal Dash Address (without Dash URI DIP: aj-contact-scanback features) - [x] Check if XkeyID exists -- [x] Add `updatedAt` property to IndexedDB Stores \ No newline at end of file +- [x] Add `updatedAt` property to IndexedDB Stores + + + +### Bugs +#### Mobile Specific +- [ ] Copy Buttons don't seem to work reliably +- [x] ~~Toggle Show/Hide password fields is also sketchy~~ + - should be fixed by +- [ ] Pairing via QR Code looks like it works, yet clicking save ends with an unpaired contact +- [ ] Unique Alias Collision with only the one contact you're trying to pair with +- [ ] Encrypted Full Backup & Backup Keystore fail to open "Save file dialog" in brave on android +- [ ] Edit Profile, Add Contact & Insufficient Wallet Funds Dialogs have layout issues on mobile + +#### General +- [ ] Dialog: Confirm Wallet Lock buttons need `line-height: 1;` +- [x] ~~Backup Keystore & Show Seed Phrase failed on initial load but worked after browser refresh~~ + - should be fixed by + +### Enhancements +- [ ] Dialog: Sent Funds Confirmation + - currently send closes, and you see your balance change + - we should show a "Funds Sent" type dialog with a link to the Transaction ID +- [ ] Batch Generate tweaks + - need to check each address funds and generate 20 past the last address with funds + - need to pre-generate accounts with some addresses when importing a phrase to start adding contacts after the last account with funds \ No newline at end of file From 06e6dd6b9480f409a516a07fb400114a1c8a92fa Mon Sep 17 00:00:00 2001 From: jojobyte <184880+jojobyte@users.noreply.github.com> Date: Wed, 7 Feb 2024 16:00:23 -0700 Subject: [PATCH 02/47] fix(ui): :adhesive_bandage: diable autocomplete & update style for Keystore/Backup upload --- src/components/dialog.js | 1 + src/components/input-amount.js | 1 + src/rigs/add-contact.js | 1 + src/rigs/edit-contact.js | 1 + src/rigs/edit-profile.js | 1 + src/rigs/phrase-backup.js | 1 + src/rigs/phrase-generate.js | 1 + src/rigs/phrase-import.js | 8 +++++--- src/rigs/send-or-request.js | 1 + src/rigs/wallet-decrypt.js | 1 + src/rigs/wallet-encrypt.js | 1 + 11 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/components/dialog.js b/src/components/dialog.js index ddda3c5..adb1629 100644 --- a/src/components/dialog.js +++ b/src/components/dialog.js @@ -72,6 +72,7 @@ const initialState = { placeholder="Do Something" minlength="1" spellcheck="false" + autocomplete="off" />

Some instructions

diff --git a/src/components/input-amount.js b/src/components/input-amount.js index f0f8e0c..14fe8a2 100644 --- a/src/components/input-amount.js +++ b/src/components/input-amount.js @@ -25,6 +25,7 @@ const initialState = { min="0" step=".00001" spellcheck="false" + autocomplete="off" /> diff --git a/src/rigs/add-contact.js b/src/rigs/add-contact.js index 3e7f44f..27d9618 100644 --- a/src/rigs/add-contact.js +++ b/src/rigs/add-contact.js @@ -201,6 +201,7 @@ export let addContactRig = (function (globals) { placeholder="your_alias" pattern="${ALIAS_REGEX.source}" spellcheck="false" + autocomplete="off" value="${state.contact?.alias || ''}" /> diff --git a/src/rigs/edit-contact.js b/src/rigs/edit-contact.js index 6784002..942ea38 100644 --- a/src/rigs/edit-contact.js +++ b/src/rigs/edit-contact.js @@ -192,6 +192,7 @@ export let editContactRig = (function (globals) { placeholder="your_alias" pattern="${ALIAS_REGEX.source}" spellcheck="false" + autocomplete="off" value="${state.contact?.alias}" /> diff --git a/src/rigs/edit-profile.js b/src/rigs/edit-profile.js index 418e16a..02952b0 100644 --- a/src/rigs/edit-profile.js +++ b/src/rigs/edit-profile.js @@ -92,6 +92,7 @@ export let editProfileRig = (function (globals) { pattern="${ALIAS_REGEX.source}" required spellcheck="false" + autocomplete="off" />

Alias others can call you (similar to a @username)

diff --git a/src/rigs/phrase-backup.js b/src/rigs/phrase-backup.js index d495423..257c0e1 100644 --- a/src/rigs/phrase-backup.js +++ b/src/rigs/phrase-backup.js @@ -54,6 +54,7 @@ export let phraseBackupRig = (function (globals) {
${phraseToEl( state.wallet?.recoveryPhrase diff --git a/src/rigs/phrase-generate.js b/src/rigs/phrase-generate.js index ee8355b..0354d9a 100644 --- a/src/rigs/phrase-generate.js +++ b/src/rigs/phrase-generate.js @@ -60,6 +60,7 @@ export let phraseGenerateRig = (function (globals) { pattern="${ALIAS_REGEX.source}" required spellcheck="false" + autocomplete="off" />
diff --git a/src/rigs/phrase-import.js b/src/rigs/phrase-import.js index 3a1bbdc..4c28212 100644 --- a/src/rigs/phrase-import.js +++ b/src/rigs/phrase-import.js @@ -74,9 +74,9 @@ export let phraseImportRig = (function (globals) { Select a
- - Keystore or Backup -
+ Keystore + or + Backup
file ` @@ -122,6 +122,7 @@ export let phraseImportRig = (function (globals) { placeholder="zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo wrong" pattern="${PHRASE_REGEX.source}" spellcheck="false" + autocomplete="off" />