merge bitcoin#27317: Check that the timestamp string is non-empty to avoid undefined behavior

kwvg · kwvg · commit 2eef89c0291b · 2025-11-03T15:41:39.000+05:30
diff --git a/src/logging.cpp b/src/logging.cpp
@@ -395,7 +395,7 @@ std::string BCLog::Logger::LogTimestampStr(const std::string& str)
     if (m_started_new_line) {
         int64_t nTimeMicros = GetTimeMicros();
         strStamped = FormatISO8601DateTime(nTimeMicros/1000000);
-        if (m_log_time_micros) {
+        if (m_log_time_micros && !strStamped.empty()) {
             strStamped.pop_back();
             strStamped += strprintf(".%06dZ", nTimeMicros%1000000);
         }

Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,7 @@ std::string BCLog::Logger::LogTimestampStr(const std::string& str)`
`395`	`395`	`if (m_started_new_line) {`
`396`	`396`	`int64_t nTimeMicros = GetTimeMicros();`
`397`	`397`	`strStamped = FormatISO8601DateTime(nTimeMicros/1000000);`
`398`		`- if (m_log_time_micros) {`
	`398`	`+ if (m_log_time_micros && !strStamped.empty()) {`
`399`	`399`	`strStamped.pop_back();`
`400`	`400`	`strStamped += strprintf(".%06dZ", nTimeMicros%1000000);`
`401`	`401`	`}`