refactor: use std::move for CQuorumCPtr in StartCachePopulatorThread

Author: PastaPastaPasta

src/llmq/quorums.cpp

@@ -883,7 +883,7 @@ MessageProcessingResult CQuorumManager::ProcessMessage(CNode& pfrom, CConnman& c
     return {};
 }
 
-void CQuorumManager::StartCachePopulatorThread(const CQuorumCPtr pQuorum) const
+void CQuorumManager::StartCachePopulatorThread(CQuorumCPtr pQuorum) const
 {
     if (!pQuorum->HasVerificationVector()) {
         return;
@@ -896,7 +896,7 @@ void CQuorumManager::StartCachePopulatorThread(const CQuorumCPtr pQuorum) const
             pQuorum->m_quorum_base_block_index->GetBlockHash().ToString());
 
     // when then later some other thread tries to get keys, it will be much faster
-    workerPool.push([pQuorum, t, this](int threadId) {
+    workerPool.push([pQuorum = std::move(pQuorum), t, this](int threadId) {
         for (const auto i : irange::range(pQuorum->members.size())) {
             if (quorumThreadInterrupt) {
                 break;

src/llmq/quorums.h

@@ -311,7 +311,7 @@ class CQuorumManager
     /// should receive the same number of request if all active llmqType members requests data from one llmqType quorum.
     size_t GetQuorumRecoveryStartOffset(const CQuorum& quorum, const CBlockIndex* pIndex) const;
 
-    void StartCachePopulatorThread(const CQuorumCPtr pQuorum) const;
+    void StartCachePopulatorThread(CQuorumCPtr pQuorum) const;
     void StartQuorumDataRecoveryThread(CConnman& connman, CQuorumCPtr pQuorum, const CBlockIndex* pIndex,
                                        uint16_t nDataMask) const;