chore: run clang-format and add trivial headers

PastaPastaPasta · PastaPastaPasta · commit ee42c15cfa85 · 2025-10-26T11:45:56.000-05:00
diff --git a/src/bench/bls.cpp b/src/bench/bls.cpp
@@ -364,7 +364,7 @@ static void BLS_ToBytes_Signature(benchmark::Bench& bench)
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto sig = sk.Sign(uint256::ONE, false);
-    
+
     bench.run([&] {
         auto bytes = sig.ToBytes(false);
         ankerl::nanobench::doNotOptimizeAway(bytes);
@@ -376,7 +376,7 @@ static void BLS_ToByteVector_Signature(benchmark::Bench& bench)
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto sig = sk.Sign(uint256::ONE, false);
-    
+
     bench.run([&] {
         auto bytes = sig.ToByteVector(false);
         ankerl::nanobench::doNotOptimizeAway(bytes);
@@ -388,7 +388,7 @@ static void BLS_ToBytes_PubKey(benchmark::Bench& bench)
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto pk = sk.GetPublicKey();
-    
+
     bench.run([&] {
         auto bytes = pk.ToBytes(false);
         ankerl::nanobench::doNotOptimizeAway(bytes);
@@ -400,7 +400,7 @@ static void BLS_ToByteVector_PubKey(benchmark::Bench& bench)
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto pk = sk.GetPublicKey();
-    
+
     bench.run([&] {
         auto bytes = pk.ToByteVector(false);
         ankerl::nanobench::doNotOptimizeAway(bytes);
@@ -412,7 +412,7 @@ static void BLS_Serialize_Signature_Array(benchmark::Bench& bench)
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto sig = sk.Sign(uint256::ONE, false);
-    
+
     bench.run([&] {
         CDataStream ss(SER_NETWORK, PROTOCOL_VERSION);
         ss << sig;
@@ -425,7 +425,7 @@ static void BLS_Serialize_Signature_Vector(benchmark::Bench& bench)
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto sig = sk.Sign(uint256::ONE, false);
-    
+
     bench.run([&] {
         CDataStream ss(SER_NETWORK, PROTOCOL_VERSION);
         auto vec = sig.ToByteVector(false);
diff --git a/src/governance/vote.h b/src/governance/vote.h
@@ -7,6 +7,7 @@
 
 #include <hash.h>
 #include <primitives/transaction.h>
+#include <span.h>
 #include <uint256.h>
 #include <util/string.h>
 
diff --git a/src/masternode/node.h b/src/masternode/node.h
@@ -67,7 +67,8 @@ class CActiveMasternodeManager
     [[nodiscard]] bool Decrypt(const EncryptedObj<Obj>& obj, size_t idx, Obj& ret_obj, int version) const
         EXCLUSIVE_LOCKS_REQUIRED(!cs);
     [[nodiscard]] CBLSSignature Sign(const uint256& hash, const bool is_legacy) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
-    [[nodiscard]] std::array<uint8_t, BLS_CURVE_SIG_SIZE> SignBasic(const uint256& hash) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
+    [[nodiscard]] std::array<uint8_t, BLS_CURVE_SIG_SIZE> SignBasic(const uint256& hash) const
+        EXCLUSIVE_LOCKS_REQUIRED(!cs);
 
     /* TODO: Reconsider external locking */
     [[nodiscard]] COutPoint GetOutPoint() const { READ_LOCK(cs); return m_info.outpoint; }
diff --git a/src/serialize.h b/src/serialize.h
@@ -10,6 +10,7 @@
 
 #include <algorithm>
 #include <atomic>
+#include <array>
 #include <concepts>
 #include <cstdint>
 #include <cstring>
diff --git a/src/test/bls_tests.cpp b/src/test/bls_tests.cpp
@@ -597,14 +597,14 @@ BOOST_AUTO_TEST_CASE(bls_tobytes_vs_tobytevector_signature)
 {
     // Test that ToBytes() and ToByteVector() produce identical results for signatures
     bls::bls_legacy_scheme.store(false);
-    
+
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto sig = sk.Sign(uint256::ONE, false);
-    
+
     auto bytes_array = sig.ToBytes(false);
     auto bytes_vector = sig.ToByteVector(false);
-    
+
     BOOST_CHECK_EQUAL(bytes_array.size(), BLS_CURVE_SIG_SIZE);
     BOOST_CHECK_EQUAL(bytes_vector.size(), BLS_CURVE_SIG_SIZE);
     BOOST_CHECK(std::equal(bytes_array.begin(), bytes_array.end(), bytes_vector.begin()));
@@ -614,14 +614,14 @@ BOOST_AUTO_TEST_CASE(bls_tobytes_vs_tobytevector_pubkey)
 {
     // Test that ToBytes() and ToByteVector() produce identical results for public keys
     bls::bls_legacy_scheme.store(false);
-    
+
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto pk = sk.GetPublicKey();
-    
+
     auto bytes_array = pk.ToBytes(false);
     auto bytes_vector = pk.ToByteVector(false);
-    
+
     BOOST_CHECK_EQUAL(bytes_array.size(), BLS_CURVE_PUBKEY_SIZE);
     BOOST_CHECK_EQUAL(bytes_vector.size(), BLS_CURVE_PUBKEY_SIZE);
     BOOST_CHECK(std::equal(bytes_array.begin(), bytes_array.end(), bytes_vector.begin()));
@@ -631,13 +631,13 @@ BOOST_AUTO_TEST_CASE(bls_tobytes_vs_tobytevector_seckey)
 {
     // Test that ToBytes() and ToByteVector() produce identical results for secret keys
     bls::bls_legacy_scheme.store(false);
-    
+
     CBLSSecretKey sk;
     sk.MakeNewKey();
-    
+
     auto bytes_array = sk.ToBytes(false);
     auto bytes_vector = sk.ToByteVector(false);
-    
+
     BOOST_CHECK_EQUAL(bytes_array.size(), BLS_CURVE_SECKEY_SIZE);
     BOOST_CHECK_EQUAL(bytes_vector.size(), BLS_CURVE_SECKEY_SIZE);
     BOOST_CHECK(std::equal(bytes_array.begin(), bytes_array.end(), bytes_vector.begin()));
@@ -647,29 +647,29 @@ BOOST_AUTO_TEST_CASE(bls_signature_array_serialization)
 {
     // Test that BLS signatures serialize correctly with std::array
     bls::bls_legacy_scheme.store(false);
-    
+
     CBLSSecretKey sk;
     sk.MakeNewKey();
     auto sig = sk.Sign(uint256::ONE, false);
-    
+
     // Serialize using standard serialization
     CDataStream ss(SER_NETWORK, PROTOCOL_VERSION);
     ss << sig;
-    
+
     // Deserialize
     CBLSSignature sig2;
     ss >> sig2;
-    
+
     BOOST_CHECK(sig == sig2);
-    
+
     // Verify the serialized size is exactly BLS_CURVE_SIG_SIZE (no size prefix)
     CDataStream ss2(SER_NETWORK, PROTOCOL_VERSION);
     ss2 << sig;
     BOOST_CHECK_EQUAL(ss2.size(), BLS_CURVE_SIG_SIZE);
-    
+
     // Test array assignment from ToBytes
     std::array<uint8_t, BLS_CURVE_SIG_SIZE> sig_array = sig.ToBytes(false);
-    
+
     // Construct signature from array via Span
     CBLSSignature sig3(Span{sig_array}, false);
     BOOST_CHECK(sig == sig3);
diff --git a/src/test/serialize_tests.cpp b/src/test/serialize_tests.cpp
@@ -313,10 +313,10 @@ BOOST_AUTO_TEST_CASE(array_serialization_bytes)
     std::array<uint8_t, 4> arr_in = {0x01, 0x02, 0x03, 0x04};
     CDataStream ss(SER_DISK, PROTOCOL_VERSION);
     ss << arr_in;
-    
+
     // Should serialize without size prefix for byte arrays
     BOOST_CHECK_EQUAL(ss.size(), 4);
-    
+
     std::array<uint8_t, 4> arr_out;
     ss >> arr_out;
     BOOST_CHECK(arr_in == arr_out);
@@ -328,7 +328,7 @@ BOOST_AUTO_TEST_CASE(array_serialization_integers)
     std::array<int32_t, 3> arr_in = {100, 200, 300};
     CDataStream ss(SER_DISK, PROTOCOL_VERSION);
     ss << arr_in;
-    
+
     std::array<int32_t, 3> arr_out;
     ss >> arr_out;
     BOOST_CHECK(arr_in == arr_out);
@@ -340,7 +340,7 @@ BOOST_AUTO_TEST_CASE(array_serialization_bools)
     std::array<bool, 5> arr_in = {true, false, true, true, false};
     CDataStream ss(SER_DISK, PROTOCOL_VERSION);
     ss << arr_in;
-    
+
     std::array<bool, 5> arr_out;
     ss >> arr_out;
     BOOST_CHECK(arr_in == arr_out);
@@ -353,7 +353,7 @@ BOOST_AUTO_TEST_CASE(array_serialization_empty)
     CDataStream ss(SER_DISK, PROTOCOL_VERSION);
     ss << arr_in;
     BOOST_CHECK_EQUAL(ss.size(), 0);
-    
+
     std::array<uint8_t, 0> arr_out;
     ss >> arr_out;
 }
@@ -365,11 +365,11 @@ BOOST_AUTO_TEST_CASE(array_serialization_bls_signature)
     for (size_t i = 0; i < BLS_CURVE_SIG_SIZE; ++i) {
         arr_in[i] = static_cast<uint8_t>(i);
     }
-    
+
     CDataStream ss(SER_DISK, PROTOCOL_VERSION);
     ss << arr_in;
     BOOST_CHECK_EQUAL(ss.size(), BLS_CURVE_SIG_SIZE);
-    
+
     std::array<uint8_t, BLS_CURVE_SIG_SIZE> arr_out;
     ss >> arr_out;
     BOOST_CHECK(arr_in == arr_out);
@@ -381,19 +381,19 @@ BOOST_AUTO_TEST_CASE(array_serialization_multiple)
     std::array<uint8_t, BLS_CURVE_PUBKEY_SIZE> arr1;
     std::array<uint8_t, BLS_CURVE_SIG_SIZE> arr2;
     std::array<int32_t, 2> arr3 = {42, 84};
-    
+
     for (size_t i = 0; i < BLS_CURVE_PUBKEY_SIZE; ++i) arr1[i] = static_cast<uint8_t>(i);
     for (size_t i = 0; i < BLS_CURVE_SIG_SIZE; ++i) arr2[i] = static_cast<uint8_t>(255 - i);
-    
+
     CDataStream ss(SER_DISK, PROTOCOL_VERSION);
     ss << arr1 << arr2 << arr3;
-    
+
     std::array<uint8_t, BLS_CURVE_PUBKEY_SIZE> arr1_out;
     std::array<uint8_t, BLS_CURVE_SIG_SIZE> arr2_out;
     std::array<int32_t, 2> arr3_out;
-    
+
     ss >> arr1_out >> arr2_out >> arr3_out;
-    
+
     BOOST_CHECK(arr1 == arr1_out);
     BOOST_CHECK(arr2 == arr2_out);
     BOOST_CHECK(arr3 == arr3_out);
