feat: credits top-up warning #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn-McJ
commented
Jul 23, 2024
| } | ||
|
|
||
| @Published var amount: AmountObject! | ||
|
|
There was a problem hiding this comment.
Currently, with how the BaseAmountViewController works, it's confusing where descendants should watch for amount updates - in an overridden method or in the amountChangeHandler of the model.
To fix this, I've hidden the methods and only the amount field is exposed on the model. It's made @Published to allow multiple subscribers with Combine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We want to show a warning dialog if the user is low on credits and allow them to buy more.
What was done?
How Has This Been Tested?
QA
Breaking Changes
Checklist:
For repository code-owners and collaborators only