fix(dashmate): increase HTTP timeout to Github / MNOWatch #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Quantum Explorer <[email protected]>
Co-authored-by: Quantum Explorer <[email protected]>
Co-authored-by: thephez <[email protected]>
…on prepare_proposal (#2041) Co-authored-by: Quantum Explorer <[email protected]>
Co-authored-by: Lukasz Klimek <[email protected]>
…istribution (#2032) Co-authored-by: Ivan Shumkov <[email protected]>
Co-authored-by: Quantum Explorer <[email protected]>
shumkov
requested changes
Aug 14, 2024
| @@ -1,6 +1,6 @@ | |||
| import { PortStateEnum } from './enums/portState.js'; | |||
|
|
|||
| const MAX_REQUEST_TIMEOUT = 5000; | |||
| const MAX_REQUEST_TIMEOUT = 60000; | |||
There was a problem hiding this comment.
We can't wait 1 to respond with status command. I recommend to keep 7 second and print some specific warning like response from service is timed out
|
@pshenmic please reopen PR if are are going to proceed on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The client HTTP timeout set by default is too low for the status function. In case of big IO, especially on the sync, it takes more time to receive response from the server, it leads to invalid port state being shown in the dashmate status.
What was done?
Increased client HTTP timeout from 6 seconds to 60 seconds
How Has This Been Tested?
By community member
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only