Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behavior and new attrs argument to all high-level functions #406

Open
agoose77 opened this issue Nov 8, 2023 · 3 comments
Open

Add behavior and new attrs argument to all high-level functions #406

agoose77 opened this issue Nov 8, 2023 · 3 comments

Comments

@agoose77
Copy link
Collaborator

agoose77 commented Nov 8, 2023

behavior is missing from many functions, and we also want to add the new attrs argument that will appear in 2.5.0.

@GaetanLepage
Copy link

Is that what is causing the breakage of coffea with dask-awkward==2023.11.1 ?

==================================== ERRORS ====================================
________________ ERROR collecting tests/test_analysis_tools.py _________________
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/runner.py:341: in from_call
    result: Optional[TResult] = func()
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/runner.py:372: in <lambda>
    call = CallInfo.from_call(lambda: list(collector.collect()), "collect")
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/python.py:531: in collect
    self._inject_setup_module_fixture()
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/python.py:545: in _inject_setup_module_fixture
    self.obj, ("setUpModule", "setup_module")
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/python.py:310: in obj
    self._obj = obj = self._getobj()
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/python.py:528: in _getobj
    return self._importtestmodule()
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/python.py:617: in _importtestmodule
    mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/pathlib.py:567: in import_path
    importlib.import_module(module_name)
/nix/store/ffll6glz3gwx342z0ch8wx30p5cnqz1z-python3-3.11.5/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
/nix/store/lhjsx27ijd31l8qgxkv5rv1z0c3hs7pn-python3.11-pytest-7.4.2/lib/python3.11/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
tests/test_analysis_tools.py:21: in <module>
    ).events()
/nix/store/z1qi0lssg0gf24xpmya0afs0wa7f0n9h-python3.11-coffea-2023.10.0.rc1/lib/python3.11/site-packages/coffea/nanoevents/factory.py:711: in events
    events.behavior["__original_array__"] = lambda: events
E   TypeError: 'NoneType' object does not support item assignment
=============================== warnings summary ===============================
../../nix/store/z1qi0lssg0gf24xpmya0afs0wa7f0n9h-python3.11-coffea-2023.10.0.rc1/lib/python3.11/site-packages/coffea/nanoevents/schemas/nanoaod.py:243
  /nix/store/z1qi0lssg0gf24xpmya0afs0wa7f0n9h-python3.11-coffea-2023.10.0.rc1/lib/python3.11/site-packages/coffea/nanoevents/schemas/nanoaod.py:243: RuntimeWarning: Missing cross-reference index for FatJet_genJetAK8Idx => GenJetAK8
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
SKIPPED [2] tests/processor/servicex/__init__.py:30: could not import 'servicex': No module named 'servicex'
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=================== 2 skipped, 1 warning, 1 error in 12.20s ====================

@douglasdavis
Copy link
Collaborator

Unsure- we're still investigating this and have yanked the 2023.11.1 release in the meantime!

@douglasdavis
Copy link
Collaborator

@GaetanLepage this issue is unrelated to the coffea failure, that issue will be fixed by #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants