Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_options inconsistency between read_deltalake and to_deltalake #55

Open
j-bennet opened this issue Jul 19, 2023 · 0 comments
Open

Comments

@j-bennet
Copy link
Collaborator

In to_deltalake, there's a kwarg called storage_options:

    storage_options : dict[str, str] | None. Default None
        Options passed to the native delta filesystem. Unused if 'filesystem' is defined

In read_deltalake, we also have a kwarg called storage_options:

    storage_options : dict, default None
        Key/value pairs to be passed on to the fsspec backend, if any.

They are not the same options. The same options in read_deltalake are called delta_storage_options:

    delta_storage_options : dict, default None
        Key/value pairs to be passed on to the delta-rs filesystem, if any.

This is confusing. We better align the two APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant