Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get rid of filters_to_expression? #59

Open
j-bennet opened this issue Jul 20, 2023 · 0 comments
Open

Can we get rid of filters_to_expression? #59

j-bennet opened this issue Jul 20, 2023 · 0 comments

Comments

@j-bennet
Copy link
Collaborator

Currently in dask-deltatable, we're using pyarrow.dataset.dataset, which we filter with a pyarrow.Expression:

.to_table(filter=filter_expression, columns=self.columns)

Would the ParquetDataset be more appropriate here? It can accept filters as Expression, or tuple/DNF form, which would allow us to skip that filters_to_expression step.

https://arrow.apache.org/docs/python/generated/pyarrow.parquet.ParquetDataset.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant