-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][GPU Error Bug] "SELECT ((<string>)!=(<column>)) FROM <tables>" brings Error #1231
Comments
I have also encountered the same situation. Can the developer reply? |
It looks like the underlying issue here is that dask-cuDF is failing because we're trying to do a binop between a float column and a string scalar: import cudf
import dask_cudf
s = cudf.Series(["A"])
ds = dask_cudf.from_cudf(s, npartitions=1)
ds != "A" On dask-sql's end, it seems like the specific combination of cross joins planned when selecting from all 3 tables in your reproducer is making it such that |
Okay seems like the issue here is handling of duplicate column names on GPU, it looks like the cross join itself fails with 3 tables: import pandas as pd
import dask.dataframe as dd
from dask_sql import Context
c = Context()
c.create_table('df1', pd.DataFrame({"a": [1]}), gpu=True)
c.create_table('df2', pd.DataFrame({"a": [2]}), gpu=True)
c.create_table('df3', pd.DataFrame({"a": [3]}), gpu=True)
query = "SELECT * FROM df1, df2, df3"
explain = c.explain(query)
res = c.sql(query) # AssertionError There's a good chance that this could be related to #1133 and potentially resolved with #1134, I can look into reviving that PR and giving it a try here EDIT: Tried #1134 without much luck, looks like the cross join issue is independent of CPU/GPU as I get errors with the above block even when |
Trying out your reproducer with #1250, I'm now able to get things passing:
Would you mind giving this branch a look on your end? |
What happened:
"SELECT ((<string>)!=(<column>)) FROM <tables>" brings error, when using GPU.
However it is able to output result, when using CPU.
What you expected to happen:
It will not bring error, when using GPU.
Minimal Complete Verifiable Example:
Result:
Anything else we need to know?:
Environment:
The text was updated successfully, but these errors were encountered: