-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observations from 2021.8.1 automatic release #180
Comments
For reference, since our dask-docker/.github/workflows/build.yml Line 78 in 3362618
I ended up manually deleting the 2021.8.1 tag (which was generated from the |
Thanks for writing this up @jrbourbeau. I'll take a look at these. |
Curious how many of these are still issues |
IIUC all of the unchecked boxes in the original post are still valid |
I've fixed up a few things and checked a few boxes in the post above that I can confirm as resolved. The last outstanding one is the auto merge, I'm not sure if this is fixed by the other changes I've made so let's wait until the next release and see what happens. cc @jrbourbeau @jsignell. |
ping @jrbourbeau @jsignell how did things go with the latest release? I see some extra changes were pushed to the PR so I'm guessing the find and replace still isn't working quite right, and the automerge didn't work. Is there anything else? |
Yeah, that's correct. I also noticed that the autotag workflow did assign a |
A couple unexpected things happened with the latest automatic release procedure:
automerge
label was applied to the PR, it wasn't automatically merged after all CI checks passed. xref Update Dask version to 2021.8.1 #178build
CI jobs ran on Update Dask version to 2021.8.1 #178. I suspect this is because we're triggering on bothpull_request
andpush
eventsdask-docker/.github/workflows/build.yml
Line 3 in e82ac06
release: XXXX.XX.X
field inbuild/docker-compose.yml
but not.github/workflows/build.yml
(xref Bump to 2021.8.1 in docker build workflow #179). EDIT: fixed by Updatewatch-conda-forge
include regex #181The text was updated successfully, but these errors were encountered: