Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor shuffle method to handle invalid columns #1091

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Refactor shuffle method to handle invalid columns #1091

merged 8 commits into from
Jun 24, 2024

Conversation

alex-rakowski
Copy link
Contributor

@alex-rakowski alex-rakowski commented Jun 24, 2024 •
edited by phofl
Loading

closes dask/dask#11174

Handles shuffling on columns that do not exist. Raises a KeyError.

phofl
phofl reviewed Jun 24, 2024
View reviewed changes
dask_expr/_collection.py Outdated Show resolved Hide resolved
@alex-rakowski
Copy link
Contributor Author

Only dask_expr/tests/test_groupby.py::test_groupby_index_array fails which is expected.

phofl
phofl requested changes Jun 24, 2024
View reviewed changes
dask_expr/tests/test_shuffle.py Outdated Show resolved Hide resolved
dask_expr/tests/test_shuffle.py Outdated Show resolved Hide resolved
dask_expr/_collection.py Show resolved Hide resolved
@phofl phofl changed the title chore: Refactor shuffle method to handle invalid columns Refactor shuffle method to handle invalid columns Jun 24, 2024
@phofl phofl merged commit cb121cd into dask:main Jun 24, 2024
3 of 7 checks passed
@phofl
Copy link
Collaborator

phofl commented Jun 24, 2024

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shuffle not raising exception when on does not exist
2 participants
@alex-rakowski @phofl