-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't stop Adaptive on error #8871
Merged
hendrikmakait
merged 6 commits into
dask:main
from
hendrikmakait:dont-stop-adaptive-on-oserror
Sep 27, 2024
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2b2a699
Don't stop Adaptive on error
hendrikmakait 4852bd2
Fix import
hendrikmakait 831675f
Refactor and add bi-directional checking for adaptive stopping
hendrikmakait 1a92d24
int | float
hendrikmakait 488480b
int | float
hendrikmakait b42358a
Merge branch 'main' into dont-stop-adaptive-on-oserror
hendrikmakait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this is a little confusing given that we actually either want
int
ormath.inf
, perdistributed/distributed/deploy/adaptive_core.py
Lines 112 to 113 in 8bafad5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong feelings here, this just follow the numeric tower in PEP 484, i.e.,
int | float
can be simplified tofloat
. Unfortunately there isn't a canonicalINF
literal that I'm aware of, instead we havemath.inf
,float("inf")
,np.inf
, and more. Happy to change it back if people find it confusing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intuitively I would say that
None
is equivalent tomath.inf
in this case. I expect most users would assume that setting the value toNone
would not set an upper bound. They might even assume that setting it to0
does the same.Should we attempt to define an
INF
literal indask.typing
that we can use here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable but let's do that in a different PR. I'll roll my changes to the type back for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that
None
is not equivalent tomath.inf
in this case. Instead, we read the config value ifNone
is provided.