Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly convert finalize dependencies to references #8949

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

hendrikmakait
Copy link
Member

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   12h 25m 50s ⏱️ + 7m 10s
 4 130 tests ±0   4 016 ✅ + 2    111 💤 ±0  3 ❌  -  2 
55 839 runs  ±0  53 408 ✅ +38  2 426 💤 ±0  5 ❌  - 38 

For more details on these failures, see this check.

Results for commit fa773bb. ± Comparison against base commit b57cb2c.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hendrikmakait hendrikmakait marked this pull request as ready for review November 26, 2024 10:55
@hendrikmakait hendrikmakait changed the title Properly convert keys to task references in Client.compute Properly convert finalize dependencies to references Nov 26, 2024
@hendrikmakait hendrikmakait merged commit 0660dab into dask:main Nov 26, 2024
28 of 34 checks passed
@hendrikmakait hendrikmakait deleted the convert-dask-keys branch November 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants