Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequential yes/no #1

Open
markvanderloo opened this issue Oct 28, 2015 · 1 comment
Open

sequential yes/no #1

markvanderloo opened this issue Oct 28, 2015 · 1 comment
Milestone

Comments

@markvanderloo
Copy link
Member

Should guarding expressions be evaluated inside or outside the loop? Make an option to decide that.

@markvanderloo markvanderloo added this to the 0.1 milestone Oct 28, 2015
@edwindj
Copy link
Member

edwindj commented Apr 26, 2021

For the sequential evaluation, the current implementation can be optimized:

Current implementation does a lot of copying: each modifier makes a selection in a data.frame (copy), edits the selection (copy) and writes it back.

For the sequential evaluation, putting all guards and modifiers in the same within would result in only one copy of the each modified column not matter how many modifiers
But this could very well be premature optimization / non problem , not sure how the performance currently is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants