Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] Users.ListAll takes Count into account if it's specified in the request #641

Open
alexott opened this issue Oct 6, 2023 · 4 comments
Assignees

Comments

@alexott
Copy link
Contributor

alexott commented Oct 6, 2023

Description

The Users.ListAll of both account & workspace clients is returning only Count entries if it's specified in the request instead of paginating using the given information. Lack of pagination leads to SCIM backend overload on workspaces with big number of users.

Expected behavior

ListAll should fetch all users with a given Count attribute.

Other Information

  • OS: mac
  • Version: 0.22.0

Additional context
Add any other context about the problem here.

Copy link
Contributor

nfx commented Oct 6, 2023

There’s a PR to ignore pagination-related fields for iterators. And there’s discussion either or not we do “virtual iteration” for scim lists

@tcesnik-veza
Copy link
Contributor

The underlying issue is actually wrong iterator construction, described in #704.

@mgyucht
Copy link
Contributor

mgyucht commented Nov 23, 2023

@tcesnik-veza this issue existed before the change to using Iterators, but I'll make sure it is fixed soon.

@mgyucht
Copy link
Contributor

mgyucht commented Nov 29, 2023

@alexott as of release v0.26.0, the SCIM APIs do paginate by default, so you don't need to specify Count anymore (it will default to 100 users/groups/SPs), but the existing behavior of the Count field determining the total number of items to return has not changed.

@mgyucht mgyucht self-assigned this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants