SEA: Decouple Link Fetching #632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
…ionality Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <[email protected]>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <[email protected]>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <[email protected]>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
…k is informed Signed-off-by: varun-edachali-dbx <[email protected]>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
jayantsing-db
approved these changes
Jul 20, 2025
Comment on lines
+218
to
+219
| if not links_downloaded: | ||
| self._shutdown_event.set() |
There was a problem hiding this comment.
add logging, pydoc, and comments in this class
|
|
||
| def stop(self): | ||
| self._shutdown_event.set() | ||
| self._worker_thread.join() |
There was a problem hiding this comment.
will this close the worker thread?
| self._current_chunk_index = 0 | ||
| # Initialize table and position | ||
| self.table = self._create_table_from_link(first_link) | ||
| if total_chunk_count < 1: |
There was a problem hiding this comment.
nit: total_chunk_count > 0 makes it more readable
|
|
||
| row_offset = link.row_offset | ||
| row_offset = chunk_link.row_offset |
There was a problem hiding this comment.
please mention/explain at l303 in comment that link is already submitted for download at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
For efficiency, we fetch the links for data in the
SeaCloudFetchQueuein a separate thread. Link fetches are slow because they come from the bottlenecked control plane, so coupling the fetching logic with the main process slows down our fetch phase. Instead, we proactively fetch links in the background and use them when required.Note: this PR does not account for link expiry. This will be handled separately in #635.
How is this tested?
Related Tickets & Documents
N/A