Fix for describe column types #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
benc-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
benc-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
eric-wang-1990
previously approved these changes
Sep 17, 2024
benc-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
benc-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
benc-db
force-pushed
the
fix_for_describe_column_types
branch
from
aed7538 to
5909b5a
Compare
benc-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
benc-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
benc-db
added a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #779 (for UC)
Description
DESCRIBE EXTENDEDtruncates column types. For generating doc site, this is ok, but for running a dbt project, it can cause issues. Where information_schema is available, we can use it to get an un-truncated column type. Initially I was going to hide this behind a behavior flag, since both methods can have performance issues; however, during implementation I discovered that behavior flags aren't available to adapters yet, due to the current dbt-core not having flags on the RuntimeConfig object. So, plan is to use information_schema where available, as it is more correct. Once behavior flags are available, we can allow users to choose, so that if one way is less performant, they can switch.Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.