Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image doesn't use in-memory database per default #68

Closed
Sejmou opened this issue Dec 4, 2023 · 3 comments
Closed

Image doesn't use in-memory database per default #68

Sejmou opened this issue Dec 4, 2023 · 3 comments

Comments

@Sejmou
Copy link

Sejmou commented Dec 4, 2023

The documentation of this image on DockerHub mentions that it uses an 'in memory backend'. However, I tested it locally and noticed that the catalog was in fact persisted (i.e. it still existed after rebooting the container). I assume this is due to an error in the source code.

I think the connection string jdbc:sqlite:file:/tmp/iceberg_rest_mode=memory in

catalogProperties.putIfAbsent(
        CatalogProperties.URI, "jdbc:sqlite:file:/tmp/iceberg_rest_mode=memory");

needs to be replaced. Currently, this creates an iceberg_rest_mode=memory file in the tmp directory of the container that is persisted and is just a regular sqlite DB file.

@manuzhang
Copy link

From the README example, this looks to be on purpose, since you can already list namespaces on start.

@dargmuesli
Copy link

dargmuesli commented Aug 20, 2024

This seems to be fixed in the migration to apache/iceberg: https://github.com/apache/iceberg/pull/10908/files#diff-3e0c3a54cb6a1c1992b7aeaf60aaf8df6457f51f2968ff2311b9b0fd827cb150R71

@Fokko
Copy link
Contributor

Fokko commented Aug 20, 2024

Kudo's to @danielcweeks 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants