Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #103

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

V2 #103

wants to merge 3 commits into from

Conversation

rflprr
Copy link
Contributor

@rflprr rflprr commented Sep 5, 2018

No description provided.

patrickzhang123 and others added 3 commits August 14, 2018 10:28
* initial changes, 3 requests done

* added in replace and delete

* created test for datasets

* added link and remove linked dataset

* added in uplink

* removed cache

* removed my test

* modified gitignore

* removed DS store

* removed swagger, timeouts, and indented code

* removed cache

* removed unused imports and metrics

* added tests

* add test

* circleCI fix

* spacing fix

* more line removals

* more fixes

* added backoff requirement

* added uplink

* hide tests for now

* removed cache

* shortened a line

* changed setup

* changed dependecny

* comment for now

* more lint fixes

* removed uncomment

* changed fail under

* updated annotation

* shortened import

* added in pass and removed flake8 ignore

* removed my test
@rflprr
Copy link
Contributor Author

rflprr commented Sep 5, 2018

@patrickzhang123 Could you please help me understand the state of v2 and all related branches? I'd like to prune as much as we can and clearly document (add a to-do to this PR) what's left to do, so any info you can share would be appreciated.

@Yanfii
Copy link

Yanfii commented Sep 6, 2018

@rflprr Lost access to that github account, so I'm using my personal one now!
The list of currently completed Apis are:

  1. ProjectApi
  2. DatasetApi
  3. Insights
  4. Users

70% of Queries are completed as well and I should be getting around to completing that soon. Each Api should have basic documentation already.

All swagger related codegen is deleted as well.

@rflprr
Copy link
Contributor Author

rflprr commented Sep 26, 2018

Thank you, @Yanfii. I'd suggest you fork and submit the reminder of the changes as a PR into v2. Let me know if you have any questions.

@rflprr
Copy link
Contributor Author

rflprr commented Oct 29, 2018

Hi, @Yanfii. Would love to know if you intend to finish the work on this PR. Let me know, please.

@Yanfii
Copy link

Yanfii commented Nov 6, 2018

Hey @rflprr, been really busy with school this past month since it is midterm season. Should be free near end of November, and I am looking to finish it then!

@rflprr
Copy link
Contributor Author

rflprr commented Nov 8, 2018

Glad to hear, @Yanfii. Good luck with all the school work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants