Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagrams depends on all containing vocabularies #521

Open
MichalMed opened this issue Jan 2, 2024 · 1 comment
Open

Diagrams depends on all containing vocabularies #521

MichalMed opened this issue Jan 2, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MichalMed
Copy link
Contributor

I'm not sure whether this is bug or feature.

Reproduction steps:

  • open OntoGrapher with two vocabularies, e.g.
    ?vocabulary=https://Fslovník.gov.cz/generický/test1&vocabulary=https://slovník.gov.cz/generický/test2,
  • create an empty diagram,
  • try to open OntoGrapher with only one of those vocabularies, e.g. ?vocabulary=https://Fslovník.gov.cz/generický/test1,
  • you get an empty page with error in console:

react-dom.production.min.js:216 TypeError: Cannot read properties of undefined (reading 'labels')
at DiagramManagerSearch.tsx:61:44
at Array.map ()
at UB (DiagramManagerSearch.tsx:57:46)
at sa (react-dom.production.min.js:157:137)
at Za (react-dom.production.min.js:180:154)
at Ks (react-dom.production.min.js:269:343)
at Pu (react-dom.production.min.js:250:347)
at Tu (react-dom.production.min.js:250:278)
at Au (react-dom.production.min.js:250:138)
at bu (react-dom.production.min.js:243:163)
cs @ react-dom.production.min.js:216
react-dom.production.min.js:216 TypeError: Cannot read properties of undefined (reading 'color')
at DiagramManagerListItem.tsx:55:49
at Array.map ()
at BB (DiagramManagerListItem.tsx:51:52)
at sa (react-dom.production.min.js:157:137)
at Ks (react-dom.production.min.js:267:460)
at Pu (react-dom.production.min.js:250:347)
at Tu (react-dom.production.min.js:250:278)
at Au (react-dom.production.min.js:250:138)
at bu (react-dom.production.min.js:243:163)
at react-dom.production.min.js:123:115
cs @ react-dom.production.min.js:216
DiagramManagerSearch.tsx:61 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'labels')
at DiagramManagerSearch.tsx:61:44
at Array.map ()
at UB (DiagramManagerSearch.tsx:57:46)
at sa (react-dom.production.min.js:157:137)
at Za (react-dom.production.min.js:180:154)
at Ks (react-dom.production.min.js:269:343)
at Pu (react-dom.production.min.js:250:347)
at Tu (react-dom.production.min.js:250:278)
at Au (react-dom.production.min.js:250:138)
at bu (react-dom.production.min.js:243:163)

If I delete triple connecting the vocabulary to diagram (přílohový-kontext), then it works fine. I suggest this behaviour is OK as the mission control creates copies of each vocabulary, but with the canonical versions it does not work.

@MichalMed MichalMed added the bug Something isn't working label Jan 2, 2024
@bindeali
Copy link
Collaborator

bindeali commented Jan 9, 2024

I can't reproduce the bug on current main branch using slovník-test data - all that happens is the missing vocabulary is represented as a read-only vocabulary. If I delete the cache from the database, it just doesn't load, but there are no errors you describe. Can you send your testing data and commit version used, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants