From 0877977cb5a26a56ff0d716ec2804ee20c1e3dac Mon Sep 17 00:00:00 2001 From: Louis Dorard Date: Tue, 14 May 2024 15:11:00 +0200 Subject: [PATCH 1/7] Continue renaming to `visual-edit` --- docs/get-started-crud-python-api.md | 8 ++++---- dss-plugin-visual-edit/.vscode/launch.json.example | 2 +- dss-plugin-visual-edit/plugin.json | 2 +- dss-plugin-visual-edit/python-lib/webapp_utils.py | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/get-started-crud-python-api.md b/docs/get-started-crud-python-api.md index 191d98c..3d03b19 100644 --- a/docs/get-started-crud-python-api.md +++ b/docs/get-started-crud-python-api.md @@ -14,8 +14,8 @@ When running the code below in a notebook or a webapp in Dataiku, a code environ ```python import dataiku -dataiku.use_plugin_libs("editable-via-webapp") -EditableEventSourced = dataiku.import_from_plugin("editable-via-webapp", "EditableEventSourced") +dataiku.use_plugin_libs("visual-edit") +EditableEventSourced = dataiku.import_from_plugin("visual-edit", "EditableEventSourced") ``` ```python @@ -87,13 +87,13 @@ ees = EditableEventSourced.EditableEventSourced( editable_column_names=EDITABLE_COLUMN_NAMES, ) -tabulator_utils = dataiku.import_from_plugin("editable-via-webapp", "tabulator_utils") +tabulator_utils = dataiku.import_from_plugin("visual-edit", "tabulator_utils") columns = tabulator_utils.get_columns_tabulator(ees) # Define Dash layout and callbacks ### -dash_tabulator = dataiku.import_from_plugin("editable-via-webapp", "dash_tabulator") +dash_tabulator = dataiku.import_from_plugin("visual-edit", "dash_tabulator") def serve_layout(): return html.Div([ diff --git a/dss-plugin-visual-edit/.vscode/launch.json.example b/dss-plugin-visual-edit/.vscode/launch.json.example index d28cba1..33ce1c6 100644 --- a/dss-plugin-visual-edit/.vscode/launch.json.example +++ b/dss-plugin-visual-edit/.vscode/launch.json.example @@ -16,7 +16,7 @@ }, { "name": "Webapp", - "cwd": "${workspaceFolder}/webapps/edit-dataset-records/", + "cwd": "${workspaceFolder}/webapps/visual-edit/", "type": "python", "request": "launch", "module": "flask", diff --git a/dss-plugin-visual-edit/plugin.json b/dss-plugin-visual-edit/plugin.json index f86059b..20ab5d4 100644 --- a/dss-plugin-visual-edit/plugin.json +++ b/dss-plugin-visual-edit/plugin.json @@ -1,5 +1,5 @@ { - "id": "editable-via-webapp", + "id": "visual-edit", "version": "1.8.12", "meta": { "label": "Visual Edit", diff --git a/dss-plugin-visual-edit/python-lib/webapp_utils.py b/dss-plugin-visual-edit/python-lib/webapp_utils.py index 9ad3c94..1d2aa31 100644 --- a/dss-plugin-visual-edit/python-lib/webapp_utils.py +++ b/dss-plugin-visual-edit/python-lib/webapp_utils.py @@ -27,7 +27,7 @@ def get_webapp_json(webapp_ID): def find_webapp_id(original_ds_name): webapps_df = DataFrame(call_rest_api("/webapps/")) webapps_edit_df = webapps_df[ - webapps_df["type"] == "webapp_editable-via-webapp_edit-dataset-records" + webapps_df["type"] == "webapp_visual-edit_visual-edit" ] webapps_edit_df["original_ds_name"] = webapps_edit_df.apply( lambda row: get_webapp_json(row["id"]).get("config").get("original_dataset"), From 80e44e51c8dfc7030a9aeee9162a01824c800637 Mon Sep 17 00:00:00 2001 From: Louis Dorard Date: Tue, 14 May 2024 18:53:46 +0200 Subject: [PATCH 2/7] Renaming: visual-edit (continued) and DataEditor --- docs/backend/404.html | 10 +- docs/backend/index.html | 110 +++++++++--------- docs/backend/search/search_index.json | 79 ++++++++++++- docs/deploy.md | 2 +- docs/get-started-crud-python-api.md | 14 +-- ...{EditableEventSourced.py => DataEditor.py} | 6 +- dss-plugin-visual-edit/python-lib/commons.py | 12 +- .../python-lib/docs/index.md | 4 +- dss-plugin-visual-edit/python-lib/mkdocs.yml | 2 +- ...ntSourced_tests.py => DataEditor_tests.py} | 4 +- .../webapps/visual-edit/backend.py | 10 +- 11 files changed, 165 insertions(+), 88 deletions(-) rename dss-plugin-visual-edit/python-lib/{EditableEventSourced.py => DataEditor.py} (99%) rename dss-plugin-visual-edit/python-lib/tests/{EditableEventSourced_tests.py => DataEditor_tests.py} (92%) diff --git a/docs/backend/404.html b/docs/backend/404.html index 9b161ba..587afd7 100644 --- a/docs/backend/404.html +++ b/docs/backend/404.html @@ -15,7 +15,7 @@ - Data Editing Backend + Visual Edit Backend @@ -70,7 +70,7 @@