Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters in test definition not saved #85

Open
JanPeterDatakind opened this issue Apr 7, 2023 · 1 comment
Open

Parameters in test definition not saved #85

JanPeterDatakind opened this issue Apr 7, 2023 · 1 comment

Comments

@JanPeterDatakind
Copy link
Contributor

Describe the bug
When a test that uses parameters (e.g. accepted values) is defined through the UI, parameters can be entered, but the resulting entry in the dot.configured_tests table does not contain these parameters.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@bkowshik
Copy link

Created a test similar to Disallowed FP methods entered in form with different allowed values from the UI.

image

Could see these allowed values come properly in the test_parameters column. Does this mean, this issue is fixed?

test_activated|project_id  |test_id                             |scenario_id   |priority|description                                                        |impact|proposed_remediation|entity_id        |test_type                            |column_name   |column_description|test_parameters                                                                                                                                                                                                                                                |date_added                   |date_modified                |last_updated_by|
--------------+------------+------------------------------------+--------------+--------+-------------------------------------------------------------------+------+--------------------+-----------------+-------------------------------------+--------------+------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------+-----------------------------+---------------+
true          |ScanProject1|a7d358ee-fa9b-3467-b7a0-704920cbc11f|INCONSISTENT-1|       3|Test https://github.com/datakind/Data-Observation-Toolkit/issues/85|      |                    |all_flight_data  |accepted_values                      |stops         |                  |{"values": ["1", "2", "5"]}                                                                                                                                                                                                                                    |2024-12-30 21:48:01.989 +0530|2024-12-30 21:48:01.989 +0530|false          |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants