Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I develop the gem I'd be sure that every helper is really important #17

Open
DDKatch opened this issue Nov 9, 2018 · 0 comments
Open
Labels
infra Gem's behavior changes: speed changes, refactoring, tests, README updates

Comments

@DDKatch
Copy link
Contributor

DDKatch commented Nov 9, 2018

discussion from #12 issue:

Dan

@roman-dubrovsky including these helpers breaks tests executing, can we remove them from codebase because in real app we have access to methods from these helpers?

    include AbstractController::Helpers
    include ActionDispatch::Http::Cache::Request
    include ActionView::RecordIdentifier

Aleks

We can run 2-4 hours investigation raid here in order to understand whether we need to include those modules:

  1. allocate rails-views' path in gemfile to local gem
  2. change gem locally and restart rails server after it
  3. check do we need to run bundle install here ^ (not sure about gem caching)

Going with that ^ we can check the availability of helper methods without including those modules

@DDKatch DDKatch added the infra Gem's behavior changes: speed changes, refactoring, tests, README updates label Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Gem's behavior changes: speed changes, refactoring, tests, README updates
Projects
None yet
Development

No branches or pull requests

1 participant