-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API // Cleanup Gemfile #21
Comments
How often we do write admin panel for api app on rails? I think we should not remove rails-coffee, sass-rails, jquery-rails and others from gemfile. |
@MProG we don't need it at all. |
@AleksSenkou React for admin panel??? This is not rationally. We can write simple admin panel on rails very fast and very cheap for customers. |
@MProG looks reasonable to use react admin panel instead of rails |
@AleksSenkou I think database_cleaner is useful for testing. Why gem 'pg', '~> 0.18', why not 0.17 or other version. I think base gem 'pg' is enough. And same question about capistrano gem |
@AleksSenkou About react admin https://pp.vk.me/c618128/v618128952/1d0eb/wQ3EX2ci2Wk.jpg |
@MProG can you please provide useful example of |
@AleksSenkou In diffrent tests we can write some information on db. And this situations can results of work other tests is incorrect. If you test work with db you should call DatabaseCleane.clean in my opinion. |
we may have conflicts after bundle update without specifying gem versions |
check |
@AleksSenkou I don't use byebug before but i wrote description and i think this is interesting gem. |
Main Idea
Changes
Remove
sass-rails
Remove
uglifier
Remove
coffee-rails
Remove
jquery-rails
Remove
turbolinks
Remove
tzinfo-data
Remove
'jbuilder', '~> 2.4'
, because2.5
is already included in GemfileRemove
rails_layout
Remove
pry-rescue
Remove
spring-commands-rspec
Change
gem 'rubocop'
togem 'rubocop', require: false
Change
gem 'capistrano', '~> 3.0.1'
to3.6.x
versionRemove
capistrano-bundler
Add
gem 'rack-cors', require: 'rack/cors'
. Should be added by default +cors.rb
initializerNo need in
ruby '2.3.1'
. It's already specified in.ruby-version
fileLet's add
pg
gem specification, for examplegem 'pg', '~> 0.18'
Let's not have duplicated
:development
groupsGems should be installed into
vendor/bundle
folder, so usebundle install --path vendor/bundle
instead ofbundle install
Let's use new hash style, example
gem 'simplecov', require: false
instead ofgem 'simplecov', :require=>false
Example
Rails API Gemfile
P.S. Ping me if you are not agree, or have better idea.
The text was updated successfully, but these errors were encountered: