Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid route type caveat #130

Closed
r-leyshon opened this issue Sep 14, 2023 · 2 comments
Closed

invalid route type caveat #130

r-leyshon opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels
wontfix This will not be worked on
Milestone

Comments

@r-leyshon
Copy link
Contributor

Description of the Feature to be Added

For route type == 200, can we include some text at the top, explaining that the message from gtfs_kit is not helpful, and that the route_type 200 is part of the proposed extended schema that they do not recognise? I think it’s worth doing though not super urgent as anyone using this is likely to encounter this route type in their GTFS.

(OPTIONAL) Suggested Implementations

some text at the top of the table when the issue is about route type 200 (coaches)

Additional context

image
@CBROWN-ONS CBROWN-ONS added GTFS HTML Issues related to the the GTFS HTML Reports technical debt A better way is available. Fix later approach has been adopted. and removed GTFS labels Sep 25, 2023
@CBROWN-ONS
Copy link
Collaborator

CBROWN-ONS commented Sep 26, 2023

@r-leyshon I we thinking that we could add a cleaner to the cleaners module (once it's merged into dev) that cross references the 'invalid' route types with our extended route type table. Does this sound good to you?

@CBROWN-ONS CBROWN-ONS self-assigned this Oct 9, 2023
@CBROWN-ONS CBROWN-ONS added this to the sprint 5 end milestone Oct 9, 2023
@r-leyshon r-leyshon added the wontfix This will not be worked on label Aug 26, 2024
@r-leyshon
Copy link
Contributor Author

Migrated to datasciencecampus/assess_gtfs#22

@r-leyshon r-leyshon closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@r-leyshon r-leyshon removed needs triage technical debt A better way is available. Fix later approach has been adopted. GTFS HTML Issues related to the the GTFS HTML Reports labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants