Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty parquet files when batching and no destinations are within distance of origins #225

Open
ethan-moss opened this issue Dec 15, 2023 · 0 comments
Labels
analyse network needs triage technical debt A better way is available. Fix later approach has been adopted.

Comments

@ethan-moss
Copy link
Collaborator

Description of the Feature to be Added

When batching, if there are no destination centroids within distance of the origin then it writes empty parquet files.

(OPTIONAL) Suggested Implementations

After filtering to required origins and destinations in od_matrix() (and before _calculate_transport_network is called), the following snippet could be used to skip this case:

if len(dest_gdf) == 0:
    continue

Additional context

@ethan-moss ethan-moss added needs triage technical debt A better way is available. Fix later approach has been adopted. analyse network labels Dec 15, 2023
@ethan-moss ethan-moss mentioned this issue Dec 15, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyse network needs triage technical debt A better way is available. Fix later approach has been adopted.
Projects
None yet
Development

No branches or pull requests

1 participant