You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Usually bounding boxes are provided in EPSG: 4326 as a list of coordinates. Currently, the urban_centre module can only take bounding boxes in ESRI: 54009 and GeoDataFrame format, which forces the user to create the gdf before calculating the urban centre.
We should add the possibility of providing a bounding box as a list in any crs, and convert it automatically if not in ESRI: 54009.
(OPTIONAL) Suggested Implementations
A new function could be added to convert the list of coordinates to a bbox:
window_raster function within urban_centre module has a check to raise an exception if bbox crs is not ESRI: 54009. A crs reprojection with a warning could be added here instead.
Unit tests need to be amended accordingly.
Additional context
The E2E script now includes a reprojection step. This needs to be removed once this change is implemented.
The text was updated successfully, but these errors were encountered:
Description of the Feature to be Added
Usually bounding boxes are provided in
EPSG: 4326
as a list of coordinates. Currently, theurban_centre
module can only take bounding boxes inESRI: 54009
and GeoDataFrame format, which forces the user to create the gdf before calculating the urban centre.We should add the possibility of providing a bounding box as a list in any crs, and convert it automatically if not in
ESRI: 54009
.(OPTIONAL) Suggested Implementations
A new function could be added to convert the list of coordinates to a bbox:
window_raster
function withinurban_centre
module has a check to raise an exception if bbox crs is notESRI: 54009
. A crs reprojection with a warning could be added here instead.Unit tests need to be amended accordingly.
Additional context
The E2E script now includes a reprojection step. This needs to be removed once this change is implemented.
The text was updated successfully, but these errors were encountered: