297 restructure package #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
July 9, 2024 09:23
Prior to removal, checked that tutorial would render correctly by replacing local GTFS module import with assess-gtfs from PYPI install. Renders fine, though content is duplicated in assess-gtfs package, so removed from here.
r-leyshon
added
enhancement
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #299 +/- ##
==========================================
- Coverage 98.13% 0.00% -98.14%
==========================================
Files 21 11 -10
Lines 1983 868 -1115
==========================================
- Hits 1946 0 -1946
- Misses 37 868 +831
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ethan-moss I have checked outputs are the same when built with 3.9, 3.10 & 3.11 python environments. Everything passes on macos. GitHub won't let me attach the renderred html files here, so I'll share on Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #297
Motivation and Context
Removes GTFS logic & restructures package & dependencies. Updates workflows.
Type of change
How Has This Been Tested?
Test configuration details:
Advice for reviewer
Suggest building package with python 3.9, 3.10, 3.11 & checking newport TP matrix is equal. Would be a good idea to include this as an e2e test.
Checklist:
Additional comments