issue/200 API v2 Maven Module #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new process plugin api v2 module with dependency to HAPI FHIR 7.4.0, old process plugin api v1 module still has dependency to HAPI FHIR 5.1.0 * HAPI dependency versions now managed via properties hapi.fhir.version and hapi.fhir.version.v1 * upgraded HAPI FHIR dependency of DSF FHIR and DSF BPE application to 7.4.0, remove not needed workarounds and added a new ones to SnapshotGeneratorImpl and ResourceValidatorImpl in dsf-fhir-validation * added Task profile test to dsf-fhir-validation * added missing thymeleaf dependency to dsf-common-ui module * refactored code to use switch expressions with pattern matching where possible * set log level for ca.uhn.fhir.parser.LenientErrorHandler to ERROR to suppress "Unknown element 'author' found while parsing" messages generated during startup
This was
linked to
issues
Sep 4, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
wetret
approved these changes
Sep 30, 2024
dsf-bpe/dsf-bpe-process-api-v1-impl/src/main/java/dev/dsf/bpe/v1/spring/ApiServiceConfig.java
Outdated
Show resolved
Hide resolved
dsf-bpe/dsf-bpe-process-api-v2-impl/src/main/java/dev/dsf/bpe/v2/spring/ApiServiceConfig.java
Outdated
Show resolved
Hide resolved
dsf-bpe/dsf-bpe-process-api-v2-impl/src/main/java/dev/dsf/bpe/v2/variables/TargetImpl.java
Show resolved
Hide resolved
...pe/dsf-bpe-process-api-v2/src/main/java/dev/dsf/bpe/v2/activity/DefaultUserTaskListener.java
Show resolved
Hide resolved
dsf-bpe/dsf-bpe-server/src/main/java/dev/dsf/bpe/plugin/ProcessPluginApiClassLoader.java
Outdated
Show resolved
Hide resolved
dsf-bpe/dsf-bpe-server/src/main/java/dev/dsf/bpe/plugin/ProcessPluginApiClassLoader.java
Outdated
Show resolved
Hide resolved
dsf-fhir/dsf-fhir-rest-adapter/src/main/java/dev/dsf/fhir/service/ReferenceExtractorImpl.java
Outdated
Show resolved
Hide resolved
HAPI bug workaround will never be removed from API v1 implementation.
The JsonAlias annotations were introduced to allow deserialization of older TargetImpl objects in DSF 0.x that used the alias values as property names.
Introduced new HAPI version property for plugin API v2. Replaced hard-coded HAPI version numbers in dsf-bpe-server-jetty and api v2 modules with version properties.
* New ProcessPluginApiClassLoaderFactory to create ProcessPluginApiClassLoader instances with allow lists for classes and resources. * Default allowed classes and resources stored in jar internal text files for v1 and v2. Lists are incomplete for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New api infrastructure, api v2 module and upgrade to HAPI 7.4.0.
Known Issues / TODOs:
min = 3configuration, now interpreted differently by the FHIR Validator of HAPI 7.4.0 resulting in invalid Task resources. We could implement a workaround that fixes the extension StructureDefinition or release a fixed process plugin.closes #200
closes #201