Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/247 duplicate resources #250

Merged
merged 17 commits into from
Dec 17, 2024
Merged

Issue/247 duplicate resources #250

merged 17 commits into from
Dec 17, 2024

Conversation

hhund
Copy link
Member

@hhund hhund commented Nov 20, 2024

  • Adds check to make sure StructureDefinitions define a base definition
  • Fixes transaction bundle error message
  • Code cleanup
  • Unique constraints implemented as constraint trigger run after insert
  • Constraint trigger functions use postgres advisory transaction locks to ensure uniqueness checks are not executed in parallel
  • Transaction isolation level of insert/update operations changed from repeatable read to read committed, enabling dirty reads needed to allow constraint triggers to see inserts/updates executed by parallel running transactions
  • New integration test to validate parallel create operations via transaction and batch bundles as well as direct POSTs
  • Delete queries to cleanup duplicate resources from production DBs
  • Modified Task authorization rule to enforce unique draft Task resources

closes #247

* Unique constraints implemented as constraint trigger run after insert
* Constraint trigger functions use postgres advisory transaction locks
to ensure uniqueness checks are not executed in parallel
* Transaction isolation level of insert/update operations changed from
repeatable read to read committed, enabling dirty reads needed to allow
constraint triggers to see inserts/updates executed by parallel running
transactions
* New integration test to validate parallel create operations via
transaction and batch bundles as well as direct POSTs
This does not change any behavior as currently no delete authorization
rule is dependent on the DB state.
@hhund hhund added this to the 1.6.1 milestone Nov 20, 2024
@hhund hhund self-assigned this Nov 20, 2024
@hhund hhund marked this pull request as ready for review December 10, 2024 15:54
@hhund hhund requested review from schwzr and wetret December 10, 2024 15:54
log message improved by early wrapping of PSQLException
contains operators @> and <@ only work in one direction, added missing
directions to complete intersection checks
@hhund hhund merged commit ca15fd2 into develop Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate ActivityDefinition Resources Prevent Processes From Being Executed
3 participants